I2PC / xmippCore

Core functions for Xmipp and sharing with other packages (like Scipion)
GNU General Public License v3.0
4 stars 2 forks source link

Added support for half precision floating point numbers in MRCs #170

Closed oierlauzi closed 1 year ago

oierlauzi commented 1 year ago

Xmipp is now able to read and write from FP16 (mode 12) MRC files. To do so, I have integrated the half 2.2.0 library into Xmipp's codebase. This library will use intrinsic instructions to perform the conversion when available.

oierlauzi commented 1 year ago

I am pending to get some FP16 MRC files to be able to test changes and make definitive this pull request.

oierlauzi commented 1 year ago

Codesmells are coming from the half library.

albertmena commented 1 year ago

The half 2.2.0 is compatible with C++17?, the web says

supporting C++11 features Not sure what it means

albertmena commented 1 year ago

Codesmells are coming from the half library.

The most of the yes but image

oierlauzi commented 1 year ago

The half 2.2.0 is compatible with C++17?, the web says

supporting C++11 features Not sure what it means

It should be. "supporting C++11 features" means that it takes advantage of modern C++ features when available (such as constexpr). AFAIK It should be compatible with any C++ version, including C++17

albertmena commented 1 year ago

Please, review the error in the compillation: https://github.com/I2PC/xmippCore/actions/runs/4664979447/jobs/8257807619?pr=170

oierlauzi commented 1 year ago

Please, review the error in the compillation: https://github.com/I2PC/xmippCore/actions/runs/4664979447/jobs/8257807619?pr=170

Ooops, fixed it. I do not why it was compiling in my machine, as there was an error there

albertmena commented 1 year ago

Please, review the error in the compillation: https://github.com/I2PC/xmippCore/actions/runs/4664979447/jobs/8257807619?pr=170

Ooops, fixed it. I do not why it was compiling in my machine, as there was an error there

It appears after the merge devel into the branch

oierlauzi commented 1 year ago

There was another compilation issue. Fixed it

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 17 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 403 Code Smells

0.0% 0.0% Coverage
0.1% 0.1% Duplication