Closed oierlauzi closed 1 year ago
I am pending to get some FP16 MRC files to be able to test changes and make definitive this pull request.
Codesmells are coming from the half library.
The half 2.2.0 is compatible with C++17?, the web says
supporting C++11 features Not sure what it means
Codesmells are coming from the half library.
The most of the yes but
The half 2.2.0 is compatible with C++17?, the web says
supporting C++11 features Not sure what it means
It should be. "supporting C++11 features" means that it takes advantage of modern C++ features when available (such as constexpr
). AFAIK It should be compatible with any C++ version, including C++17
Please, review the error in the compillation: https://github.com/I2PC/xmippCore/actions/runs/4664979447/jobs/8257807619?pr=170
Please, review the error in the compillation: https://github.com/I2PC/xmippCore/actions/runs/4664979447/jobs/8257807619?pr=170
Ooops, fixed it. I do not why it was compiling in my machine, as there was an error there
Please, review the error in the compillation: https://github.com/I2PC/xmippCore/actions/runs/4664979447/jobs/8257807619?pr=170
Ooops, fixed it. I do not why it was compiling in my machine, as there was an error there
It appears after the merge devel into the branch
There was another compilation issue. Fixed it
SonarCloud Quality Gate failed.
17 Bugs
0 Vulnerabilities
0 Security Hotspots
403 Code Smells
Xmipp is now able to read and write from FP16 (mode 12) MRC files. To do so, I have integrated the half 2.2.0 library into Xmipp's codebase. This library will use intrinsic instructions to perform the conversion when available.