I2PC / xmippCore

Core functions for Xmipp and sharing with other packages (like Scipion)
GNU General Public License v3.0
4 stars 2 forks source link

XmippCore librares added to compiled database #192

Closed DavidHerreros closed 9 months ago

DavidHerreros commented 1 year ago

XmippCore libraries are now added to the compiled database on Xmipp compilation.

This PR needs the changes from 835 to work properly.

MartinSalinas98 commented 1 year ago
scons: *** [lib/libXmippCore] Explicit dependency `fftw3' not found, needed by target `lib/libXmippCore'.

This error keeps showing up, even with branch names matching. Taking a look at the actions, I realised that xmipp's branch name is not being taken into account.

albertmena commented 1 year ago
scons: *** [lib/libXmippCore] Explicit dependency `fftw3' not found, needed by target `lib/libXmippCore'.

This error keeps showing up, even with branch names matching. Taking a look at the actions, I realised that xmipp's branch name is not being taken into account.

same error on local compilling just xmippCore

DavidHerreros commented 1 year ago
scons: *** [lib/libXmippCore] Explicit dependency `fftw3' not found, needed by target `lib/libXmippCore'.

This error keeps showing up, even with branch names matching. Taking a look at the actions, I realised that xmipp's branch name is not being taken into account.

same error on local compilling just xmippCore

I have tried a "fresh" Xmipp installation on local following the next step:

The compilation finished without error in my case. I don't have any Xmipp library on my bash either, any ideas on how to replicate the issue to have a closer look to it @albertmena @MartinSalinas98 ? Thanks!!!

albertmena commented 1 year ago
scons: *** [lib/libXmippCore] Explicit dependency `fftw3' not found, needed by target `lib/libXmippCore'.

This error keeps showing up, even with branch names matching. Taking a look at the actions, I realised that xmipp's branch name is not being taken into account.

same error on local compilling just xmippCore

I have tried a "fresh" Xmipp installation on local following the next step:

* `xmipp cleanBin`

* `xmipp all`

* Use of `compilation_database_xmippCore` in both `xmipp` and `xmippCore` repos

The compilation finished without error in my case. I don't have any Xmipp library on my bash either, any ideas on how to replicate the issue to have a closer look to it @albertmena @MartinSalinas98 ? Thanks!!!

cd src/xmippCore
cp ../../xmipp.conf .
python $(which scons)  . -j4
DavidHerreros commented 1 year ago
scons: *** [lib/libXmippCore] Explicit dependency `fftw3' not found, needed by target `lib/libXmippCore'.

This error keeps showing up, even with branch names matching. Taking a look at the actions, I realised that xmipp's branch name is not being taken into account.

same error on local compilling just xmippCore

I have tried a "fresh" Xmipp installation on local following the next step:

* `xmipp cleanBin`

* `xmipp all`

* Use of `compilation_database_xmippCore` in both `xmipp` and `xmippCore` repos

The compilation finished without error in my case. I don't have any Xmipp library on my bash either, any ideas on how to replicate the issue to have a closer look to it @albertmena @MartinSalinas98 ? Thanks!!!

cd src/xmippCore
cp ../../xmipp.config .
python $(which scons)  . -j4

I can reproduce now the error, thanks! However, it does not happen when running the installation with Scipion (scipion3 run ./xmipp compileAndInstall). I guess the Python installed in the system does not know where those libraries are located?

MartinSalinas98 commented 1 year ago

Looks better, compilation still fails for some reason

albertmena commented 1 year ago

From now, xmippCore action compile just the xmippCore repository not all Xmipp. With this PR, the compillation doesnt run.

sonarcloud[bot] commented 1 year ago

Please retry analysis of this Pull-Request directly on SonarCloud.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud