I2PC / xmippCore

Core functions for Xmipp and sharing with other packages (like Scipion)
GNU General Public License v3.0
4 stars 2 forks source link

Fixed bugs #196

Closed MartinSalinas98 closed 9 months ago

MartinSalinas98 commented 9 months ago

@oierlauzi we have a bug here that we don't know how to solve (without possibly breaking functionality).

In summary, it's a uint_32 related to wither sine or cosine being negated, which might lead to integer overflow. Since you added this file (8 months ago), you might know what is supposed to do better than us, and therefore know how to fix this.

Thanks!

Edit: This file is full of negations of unsigned ints, it looks like the integer overlow might be intended as a "not" operation, since it is also full of other bit-wise operations such as and, right shift, xor... so it might be intended, and a false positive from SonarCloud. (needs confirmation)

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication