search

IABTechLab / iabgpp-es

Apache License 2.0
25 stars 8 forks source link

US privacy section names (`uspnat` vs `usnat` prefixes) #24

Open nhagen opened 1 year ago

nhagen commented 1 year ago

Prefixes for US National approach sections in this project are uspnat, but per the specification, shouldn't they be usnat?

ldavidson45 commented 1 year ago

Had the same concern. With the implementation deadline approaching, would like to know if this will be updated.

taraschi-sp commented 1 year ago

It looks like this was changed with the recent 1.1 updates but now the section is usnatv1.

I see that the other sections are similarly named, all having v1 appended to their prefixes.

This seems to violate the spec though, for example calling hasSection requires a prefix parameter - https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/main/Core/CMP%20API%20Specification.md#hassection-

Based on the docs it should be usnat for the section ID 7, but as implemented it would require usnatv1.

patmmccann commented 1 year ago

@taraschi-sp is accurate; usnat is correct, usnatv1 is incorrect.

gabemorazan commented 5 months ago

I'm assuming this was addressed with https://github.com/IABTechLab/iabgpp-es/pull/49 ?

jameshartig commented 5 months ago

That PR updated the Readme.md but not the actual code.