search

IABTechLab / iabgpp-java

Apache License 2.0
11 stars 13 forks source link

Invalid default value for UspNatV1Field.MSPA_COVERED_TRANSACTION? #29

Open matt-martin opened 1 year ago

matt-martin commented 1 year ago

The specification says that the valid values for MspaCoveredTransaction are:

1 Yes 2 No

But this field is given a default value of 0 here: https://github.com/IABTechLab/iabgpp-java/blob/2d39d9648443b92a572c447b015c4307822b0e09/iabgpp-encoder/src/main/java/com/iab/gpp/encoder/section/UspNatV1.java#L56

Should the spec be updated to say that 0 is valid? Or would it make sense to use a different default in the code?

patmmccann commented 1 year ago

0 is invalid; the code here is wrong