corrected flags passed to Synthesizer and extract model functions

IAHispano / Applio

A simple, high-quality voice conversion tool focused on ease of use and performance

https://applio.org

MIT License

1.82k stars 293 forks source link

corrected flags passed to Synthesizer and extract model functions #728

Closed AznamirWoW closed 2 months ago

AznamirWoW commented 2 months ago

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

AznamirWoW commented 2 months ago

Due to a bug in v3.2.5 generate_filelist was called with pitch_guidance = True/False without converting the parameter using strtobool, but the check if pich_guidance: is True regardless of x value, thus the file list was always created with full set of parameters.

Since data_utils expects all 5 values to be present in the file list, removing the logic from the generation function to simplify things.