search

IAI-Cyber / TRADES

TRADES Tool
Eclipse Public License 2.0
15 stars 6 forks source link

Fix the scrollbar layout pb caused by Control's label #1

Closed lredor closed 3 years ago

lredor commented 3 years ago

This approach does not modify the VSM. There is maybe another solution. It will be studied later.

Signed-off-by: Laurent Redor laurent.redor@obeo.fr

lredor commented 3 years ago

This PR fix the scrollbar problem, but I've just noticed that there is a side effect. Edges starting from the control are now layouted oddly. They systematically start from the top of the righr side of the Control node instead of the middle for example. I will analyze this problem but this PR should not be merged.

lredor commented 3 years ago

We can see the side effect direclty in ELK demonstrator. The first two nodes correspond to the previous behavior (border nodes for label are not centered). Below them, the border nodes for label are centered but the edge is "on the top".

lredor commented 3 years ago

I've closed this PR. It will be replaced by the PR 2 on a specific branch (as there are at least 2 solutions). So I will create one branch for each solution.