search

IAMconsortium / common-definitions

Repository for definitions and mappings in model comparison projects
Creative Commons Zero v1.0 Universal
9 stars 18 forks source link

Add multiple versions of carbon-price variables #38

Open danielhuppmann opened 7 months ago

danielhuppmann commented 7 months ago

This PR adds the carbon-price variables (with different forms of aggregation) as used in the ENGAGE project.

fyi @IAMconsortium/common-definitions-coordination

orichters commented 7 months ago

In NGFS, we also have sectoral-differentiated carbon prices because we have sector-specific policies. Worth adding something like this?

Price|Carbon|Supply
Price|Carbon|Demand|Industry
Price|Carbon|Demand|Residential and Commercial
Price|Carbon|Demand|Transportation
danielhuppmann commented 7 months ago

In NGFS, we also have sectoral-differentiated carbon prices because we have sector-specific policies.

No objections from me, but looking at the NGFS variable, I notice two issues:

  1. these variables do not have a description
  2. these variables are all weighted by "Final Energy" (not the emissions or energy use of that sector) - is that intended?

I suggest do a follow-up PR (and discuss the two issues there) once this PR is merged (after one week unless there are any objections).

orichters commented 7 months ago

We weigh by Final Energy because once you go to negative emissions in some sectors, weighing by emissions creates really strange effects such as massive spikes (dividing by ~ zero) and negative carbon prices. Fine to discuss that later.

orichters commented 7 months ago

Question: Is it really a good idea to have variables that include a part within parantheses? I'm asking because many of our scripts use strings of the format "Variable name (Unit)" and I'm a bit concerned that may mess up some of our scripts :)

I couldn't find these variable names in the Navigate / Engage / Elevate template I have, anyway (from May 26, 2023)

danielhuppmann commented 7 months ago

Right, this was added in the openENTRANCE project via https://github.com/openENTRANCE/openentrance/pull/154 per suggestion by @Renato-Rodrigues (after discussion with @robertpietzcker, if I recall correctly). The idea is to have an easy way to compare different computations for carbon price given the caveats of using negative weights.

If you think that this is too much of a distraction, I can also remove it and we start a separate PR and discuss there...

orichters commented 7 months ago

No, that is fine. If Renato proposed it, I have no doubt it is a good idea. And with the parantheses: As this basically affects only postprocessing scripts (we don't need to name it like that in REMIND), no objection to that.