Closed danielhuppmann closed 3 months ago
I think some basic variables are missing:
I also think there is a typo on definitions/variable/sdg-indicators/tag_nitrogen-sources.yaml
: Managementps
Thanks @danielhuppmann for taking this over (and sorry for disappearing a bit abruptly, everything was a bit of a rush prior to the start of my parental leave). Just checking in briefly to respond to your questions:
would it make sense to spell out MSA and BII in the variable names for clarity and readability -> agree
why are the nitrogen variables named "Cropland Budget", and how is that related to nitrogen? -> @flohump or Isabelle Weindl (weindl@pik-potsdam.de) can help here
what is V-DEM? (in the description of the indicator "Equality Before Law and Individual Liberty" -> It's Varieties of Democracy, a dataset on political institutions. See e.g. here: https://ssp-extensions.apps.ece.iiasa.ac.at/article/rule_of_law/
@VassilisDaioglou yes, good catch! This happened because we didn't include variables in the SHAPE "add-on" template that were already in the NAVIGATE template, and indeed in the rush it slipped my mind to comb through the NAVIGATE template again for those variables. Could you have a quick look through this file and make a PR with your variables and any other SDG indicators from there? https://github.com/iiasa/shape-internal-workflow/blob/main/definitions/variable/variable.yaml Thanks!
Thanks @VassilisDaioglou for adding the overlooked variables. I implemented the changes agreed by @bs538 and will open an issue on the remaining question related to cropland budget, then merge the PR.
This PR copies the PR #53 and implements a number of clean-ups (given that @bs538 indicated he could not work on this over the next weeks).
See the list of commits for a clean step-by-step reporting of the changes that I implemented beyond the work done so far, trying to implement a consistent variable-naming and use of units.
A few open questions:
Related issues: #72 #62
FYI @IAMconsortium/common-definitions-sdg-indicators