Definitions/shape sdg - Githubissues

IAMconsortium / common-definitions

Repository for definitions and mappings in model comparison projects

Creative Commons Zero v1.0 Universal

9 stars 18 forks source link

Definitions/shape sdg #77

Closed VassilisDaioglou closed 3 months ago

VassilisDaioglou commented 3 months ago

Added missing variables and some smaller connections.

danielhuppmann commented 3 months ago

Redirected this PR to the branch definitions/shape-sdg to see the difference compared to #73

VassilisDaioglou commented 3 months ago

@danielhuppmann I tried to accept your changes but some of the checks are failing and im not understanding why.

FAILED tests/test_legacy.py::test_legacy_variables - yaml.parser.ParserError: while parsing a block collection
  in "definitions/variable/sdg-indicators/sdg.yaml", line 1, column 1
expected <block end>, but found '?'
  in "definitions/variable/sdg-indicators/sdg.yaml", line 476, column 1

VassilisDaioglou commented 3 months ago

It seems like this is all ready, @danielhuppmann can you please make the required merges?