IAMconsortium / concordia

Apache License 2.0
0 stars 3 forks source link

CO2-em-removal files contain NaN sector dimensions #34

Closed coroa closed 5 months ago

coroa commented 6 months ago

In the CO2-em-removal files, the sector ids are NaN for the OAE sector:

double sector(sector) ;
        sector:_FillValue = NaN ;
        sector:long_name = "sector" ;
        sector:id = "1.0: CDR Industry; nan: CDR OAE; 0.0: CDR DACCS" ;

Also sector data type is double in these files compared to int64 in the corresponding CO2-em-anthro files.

Originally posted by @ShraddhaGupta28 in https://github.com/IAMconsortium/concordia/issues/32#issuecomment-1969073719

coroa commented 6 months ago

Thanks, @ShraddhaGupta28 for reporting that. Indeed, we noticed in the checking with daria and etienne on #32 , that the sector coordinate breaks whenever data is missing, unfortunately, instead of supplying them as 0 valued entries. This should already be fixed by the code we prepared in #33 , but i'll make sure to check that the removals are correctly represented as well. For the next update in two weeks!