search

IAMconsortium / nomenclature

A package to work with IAMC-style variable templates
https://nomenclature-iamc.readthedocs.io/
Apache License 2.0
19 stars 14 forks source link

Check for collision within a set of region mappings #25

Closed phackstock closed 3 years ago

phackstock commented 3 years ago

Building on #22, one of the next steps in verification is to check that there are no collisions within all of the provided mappings. Illustration of one failure scenario: Given mapping_1:

name: model_1
native_regions:
  - native_region_a: alternative_name

mapping_2:

name: model_2
native_regions:
  - alternative_name

Alternatively it could also be that in mapping_2 we have a region called native_region_b which we end up renaming alternative_name. In any case a next step in region mapping could be to check for this. @danielhuppmann, @peterkolp is this really an issue or is this actually fine? If it is fine, feel free to close the issue. If it is something that should be checked are there any other failure scenarios that should be checked? For the common regions it is of course expected that they share the same name.

danielhuppmann commented 3 years ago

I don't think that this is an issue - for example, having MESSAGEix-GLOBIOM 1.1 (11 regions) and MESSAGEix-GLOBIOM 1.2 (14 regions), it could make sense to rename regions that are identical in the two models to the same alternative-native-name.

phackstock commented 3 years ago

Ah ok good to know, then we can close this and can take a look at #26

phackstock commented 3 years ago

What might be important though is to check that there aren't two mappings for the same model.

danielhuppmann commented 3 years ago

What might be important though is to check that there aren't two mappings for the same model.

Yes, correct - but I guess that this should be a new issue given the discussion so far in this thread.