Add Logging to region processing

IAMconsortium / nomenclature

A package to work with IAMC-style variable templates

https://nomenclature-iamc.readthedocs.io/

Apache License 2.0

19 stars 14 forks source link

Add Logging to region processing #42

Closed phackstock closed 2 years ago

phackstock commented 2 years ago

As of right now there is no logging happening in the context of region processing. This should be changed prior to the first release.

danielhuppmann commented 2 years ago

Thanks for opening this issue. I'd go for very short logging, one line per "model" in the IamDataFrame instance:

if no mapping file exists: "No region aggregation mapping found for model {model}"
else: "Applying region aggregation mapping for model {model} from file {file}"

phackstock commented 2 years ago

That should be on the info level right? Should we log errors as well?

danielhuppmann commented 2 years ago

Yes, I'd put that as info. About errors, if the RegionProcessor config can't be loaded or pyam fails (e.g., due to invalid arguments for region-aggregation), these should be raised to the user anyway - no need to log them as well, I think...

phackstock commented 2 years ago

Ah alright, I'll keep it to info then.