IAMconsortium / pyam

Analysis & visualization of energy & climate scenarios
https://pyam-iamc.readthedocs.io/
Apache License 2.0
234 stars 120 forks source link

adds iam-units to dependency check #540

Closed gidden closed 3 years ago

gidden commented 3 years ago

Small hotfix building on #531 which adds a bit of documentation to setup.py and includes iam-units in dependencies which are kept up to date in the new workflow.

codecov[bot] commented 3 years ago

Codecov Report

Merging #540 (1954d94) into main (58e2c95) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #540   +/-   ##
=====================================
  Coverage   93.5%   93.5%           
=====================================
  Files         47      47           
  Lines       5129    5129           
=====================================
  Hits        4796    4796           
  Misses       333     333           
Impacted Files Coverage Δ
setup.py 0.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58e2c95...1954d94. Read the comment docs.

danielhuppmann commented 3 years ago

Oh, seems that the explicit iam-units version actually doesn't work...?

danielhuppmann commented 3 years ago

Seems that support for CO2e was added with https://github.com/IAMconsortium/units/pull/21, with the corresponding release on 2020.4.21

gidden commented 3 years ago

Added the commits - let's see how the pipelines work out. Appears the test is already working, though =)

danielhuppmann commented 3 years ago

Thanks @gidden