Closed znicholls closed 3 years ago
Merging #572 (7fd9c52) into main (bd6fb43) will increase coverage by
0.0%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## main #572 +/- ##
=====================================
Coverage 93.7% 93.7%
=====================================
Files 50 50
Lines 5332 5334 +2
=====================================
+ Hits 4997 4999 +2
Misses 335 335
Impacted Files | Coverage Δ | |
---|---|---|
setup.py | 0.0% <ø> (ø) |
|
pyam/core.py | 94.3% <100.0%> (ø) |
|
pyam/utils.py | 91.6% <100.0%> (+<0.1%) |
:arrow_up: |
tests/test_io.py | 100.0% <100.0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bd6fb43...7fd9c52. Read the comment docs.
This seems to not work with
xlrd==2.0.0
- maybe requirexlrd>=2.0.1
instead?
Had to make some tweaks to make sure engine passing worked, let's see what the CI says
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
Loosen the pinning of xlrd. The pin isn't needed and it's causing issues for downstream users (e.g. attempts to make openscm-runner a conda package https://github.com/conda-forge/staged-recipes/pull/15573#issuecomment-898890003). It would be great if these changes could be propagated to conda and pypi fairly quickly as a bug fix.