IAMconsortium / pyam

Analysis & visualization of energy & climate scenarios
https://pyam-iamc.readthedocs.io/
Apache License 2.0
226 stars 118 forks source link

Make categorize and filter work with a custom index #582

Closed coroa closed 2 years ago

coroa commented 2 years ago

Please confirm that this PR has done the following:

Description of PR

Implement the custom-index support in some functions - this is a beta-feature.

codecov[bot] commented 2 years ago

Codecov Report

Merging #582 (cd250cf) into main (151e330) will not change coverage. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #582   +/-   ##
=====================================
  Coverage   93.7%   93.7%           
=====================================
  Files         50      50           
  Lines       5339    5339           
=====================================
  Hits        5004    5004           
  Misses       335     335           
Impacted Files Coverage Δ
pyam/core.py 94.3% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 151e330...cd250cf. Read the comment docs.

danielhuppmann commented 2 years ago

Looks nice and compact...

danielhuppmann commented 2 years ago

Are you planning any further work on this, @coroa? If not, can you please update the description. (I'm planning to start developing structured tests for custom-index features in the near future, so no need to add specific tests now - keeping in mind that the custom-index is a beta-feature).

danielhuppmann commented 2 years ago

Merging as there was no activity, all tests pass, and it will simplify some follow-up work on my to-do list.