Closed danielhuppmann closed 2 years ago
Merging #592 (482468e) into main (732752c) will not change coverage. The diff coverage is
0.0%
.
@@ Coverage Diff @@
## main #592 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 50 50
Lines 5331 5331
=====================================
Hits 5022 5022
Misses 309 309
Impacted Files | Coverage Δ | |
---|---|---|
pyam/__init__.py | 67.5% <0.0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 732752c...482468e. Read the comment docs.
Tested this locally on both Jupyter notebooks and jupyter-lab notebooks on Mac OS with Python 3.9 and the following (selected) packages and it works as expected.
ipykernel 6.4.1
ipython 7.30.1
jupyter-client 7.1.0
jupyter-core 4.9.1
jupyter-server 1.12.1
jupyterlab 3.2.4
jupyterlab-pygments 0.1.2
jupyterlab-server 2.8.2
@stefaneidelloth, could you please install from this branch using
pip install git+https://github.com/danielhuppmann/pyam.git@notebook/jupyterlab
(recommended in a new environment) and let me know if this solves the problem on your machine?
Yes, solves the problem. Thank you!
Please confirm that this PR has done the following:
Description of PR
This PR adapts the special handling when importing pyam in a notebook. As reported by @stefaneidelloth in #591, the deactivation of in-cell scrolling for Jupyter notebooks causes a critical error in jupyter-lab notebooks.
closes #591