IAMconsortium / pyam

Analysis & visualization of energy & climate scenarios
https://pyam-iamc.readthedocs.io/
Apache License 2.0
226 stars 118 forks source link

`assert_iamframe_equals()` passes if all-nan-cols are present #608

Closed danielhuppmann closed 2 years ago

danielhuppmann commented 2 years ago

Please confirm that this PR has done the following:

Description of PR

Currently, assert_iamframe_equal() fails if one of the IamDataFrames has a meta-column of all-nan's (and the column doesn't exist in the other IamDataFrame). Arguably, all-nan should be treated as identical to "column doesn't exist".

The PR also adds a page for the testing module to the docs.

Closes #515

codecov[bot] commented 2 years ago

Codecov Report

Merging #608 (005434b) into main (28089d3) will increase coverage by 0.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #608   +/-   ##
=====================================
  Coverage   94.3%   94.3%           
=====================================
  Files         53      54    +1     
  Lines       5471    5477    +6     
=====================================
+ Hits        5162    5168    +6     
  Misses       309     309           
Impacted Files Coverage Δ
pyam/testing.py 75.0% <100.0%> (ø)
tests/test_testing.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28089d3...005434b. Read the comment docs.

phackstock commented 2 years ago

Perfect, good to merge from my side.