IAMconsortium / pyam

Analysis & visualization of energy & climate scenarios

https://pyam-iamc.readthedocs.io/

Apache License 2.0

226 stars 118 forks source link

Add AR6 category colors to PYAM_COLORS #650

Closed jkikstra closed 2 years ago

jkikstra commented 2 years ago

Description of PR

Adds the AR6 Category and IMP colours to pyam.

gidden commented 2 years ago

Thanks so much, @jkikstra! Can you also update the plot used to test against (and confirm it looks correct)? Instructions to do so should be in the test folder and can be executed on the single file/test of interest.

jkikstra commented 2 years ago

Have updated the test figures. As expected, only https://github.com/IAMconsortium/pyam/blob/56fcc56f6f38fdd9f089074379babbfb33c9a476/tests/expected_figs/test_line_PYAM_COLORS.png changed.

Tests locally are failing, but that seems to be due to pint and/or pandas_datareader, so should not really part of this PR.

danielhuppmann commented 2 years ago

Thanks @jarmo! I pinned pint as a quickfix, this should resolve the failing unit tests in this PR.

Could you please do the following:

[x] Revert the latest commit and then commit only the one changed figure to this branch
[x] Add a comment in each line explaining the meaning of the abbreviations and a reference to the description or source in the AR6 WG3 report, so that users have a chance to know what "C2" or "IMP-Neg" are...
[x] Add a line to the release notes

Then good to go, and I think this is a nice feature addition that warrants a new release (which I will take of).

codecov[bot] commented 2 years ago

Codecov Report

Merging #650 (b82fe83) into main (fff690e) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #650   +/-   ##
=====================================
  Coverage   94.5%   94.5%           
=====================================
  Files         57      57           
  Lines       5662    5662           
=====================================
  Hits        5356    5356           
  Misses       306     306

Impacted Files	Coverage Δ
pyam/plotting.py	`92.9% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fff690e...b82fe83. Read the comment docs.

jkikstra commented 2 years ago

Hi Daniel and Matt, thanks for the guidance.

I did that now.

Tried to also update the python notebook that is part of the docs, ipcc_colors.ipynb, but my IIASA desktop seems unhappy due to some dll issue in my venv, so would probably be more efficient if I leave that quick update to you.