Closed gidden closed 2 years ago
Merging #659 (b203f56) into main (c5e8f9c) will increase coverage by
0.0%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## main #659 +/- ##
=====================================
Coverage 94.5% 94.6%
=====================================
Files 59 59
Lines 5742 5765 +23
=====================================
+ Hits 5431 5454 +23
Misses 311 311
Impacted Files | Coverage Δ | |
---|---|---|
pyam/core.py | 94.6% <100.0%> (+<0.1%) |
:arrow_up: |
tests/test_core.py | 100.0% <100.0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5e8f9c...b203f56. Read the comment docs.
Thanks @coroa for suggesting the high-performance implementation alternative!
I don't mind adding the function directly for now. If discoverability becomes an issue, we could delegate methods operating only on the timeseries data to a submodule, similar to what I did with the compute
module...
Hi both - have updated based on your suggestions. Should be ready.
LGTM
Given positive response here, will go ahead with merge. See #662 for an issue on expanding documentation further.
Please confirm that this PR has done the following:
Description of PR
This PR introduces an
offset()
method which allows a user to compute offsets relative to base-time-periods in the same style asnormalize()
.