Closed phackstock closed 2 years ago
Merging #665 (f95c030) into main (c5e8f9c) will increase coverage by
0.0%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## main #665 +/- ##
=====================================
Coverage 94.5% 94.5%
=====================================
Files 59 59
Lines 5742 5747 +5
=====================================
+ Hits 5431 5436 +5
Misses 311 311
Impacted Files | Coverage Δ | |
---|---|---|
pyam/core.py | 94.5% <100.0%> (ø) |
|
tests/test_feature_append_concat.py | 100.0% <100.0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5e8f9c...f95c030. Read the comment docs.
Thanks for the quick review @danielhuppmann. If the tests all run through I'd go ahead with the merge.
Thanks for that! I literally stumbled over it last night.
Perfect coincidence then, happy to fix it.
Please confirm that this PR has done the following:
Description of PR
closes #664.
The
pyam.concat
function now carries over the index of the merged meta table. Added a unit test to check undertest_feature_append_and_concat.test_concat_non_standard_index
. For documentation I added an additional line to thenotes
section of thepyam.concat
function.One open question from my side would be if there is more documentation than the added docstring required. My hunch would be that it's fine as is since the behavior is not really new but rather more working in line with user expectations.