IAMconsortium / pyam

Analysis & visualization of energy & climate scenarios
https://pyam-iamc.readthedocs.io/
Apache License 2.0
222 stars 116 forks source link

Local file cache #696

Closed Rlamboll closed 1 year ago

Rlamboll commented 1 year ago

Done to resolve #681

Please confirm that this PR has done the following:

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

Please describe the changes introduced by this PR.

codecov[bot] commented 1 year ago

Codecov Report

Merging #696 (4acc5dd) into main (4bd16a9) will increase coverage by 0.0%. The diff coverage is 97.8%.

@@          Coverage Diff          @@
##            main    #696   +/-   ##
=====================================
  Coverage   94.8%   94.9%           
=====================================
  Files         58      58           
  Lines       5856    5900   +44     
=====================================
+ Hits        5557    5600   +43     
- Misses       299     300    +1     
Impacted Files Coverage Δ
pyam/iiasa.py 86.8% <95.6%> (+0.7%) :arrow_up:
pyam/__init__.py 67.5% <100.0%> (ø)
tests/test_iiasa.py 97.8% <100.0%> (+0.2%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Rlamboll commented 1 year ago

I've enabled it to read xls(x) files, but I don't think it's possible to do proper checks that the filters are applied in only a more restrictive sense without spending a significant period of time querying the database, which is what we're trying to avoid in the first place. I've expanded the documentation to make it clear that it's on the user to look out for this. This is consistent with how the code is currently used.