IAMconsortium / pyam

Analysis & visualization of energy & climate scenarios
https://pyam-iamc.readthedocs.io/
Apache License 2.0
222 stars 116 forks source link

Added (useful) error for using lists in filter by level #713

Closed Rlamboll closed 1 year ago

Rlamboll commented 1 year ago

…rbidden column.

Please confirm that this PR has done the following:

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

Please describe the changes introduced by this PR.

codecov[bot] commented 1 year ago

Codecov Report

Merging #713 (cb5c0b1) into main (83b7542) will increase coverage by 0.0%. The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #713   +/-   ##
=====================================
  Coverage   94.9%   94.9%           
=====================================
  Files         58      58           
  Lines       5909    5914    +5     
=====================================
+ Hits        5609    5614    +5     
  Misses       300     300           
Impacted Files Coverage Δ
pyam/_style.py 49.1% <ø> (ø)
pyam/utils.py 91.7% <100.0%> (+<0.1%) :arrow_up:
tests/test_core.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Rlamboll commented 1 year ago

@danielhuppmann The tests indicate a problem with the cached dependencies, I don't think this is related to my changes though?

danielhuppmann commented 1 year ago

@danielhuppmann The tests indicate a problem with the cached dependencies, I don't think this is related to my changes though?

Fixed via #714

danielhuppmann commented 1 year ago

Closed and reopened to re-trigger tests after fixing the dependency issues

danielhuppmann commented 1 year ago

Still failing, maybe need to rebase?

Rlamboll commented 1 year ago

OK, looks like the rebase fixed it!