search

IAMconsortium / pyam

Analysis & visualization of energy & climate scenarios
https://pyam-iamc.readthedocs.io/
Apache License 2.0
220 stars 115 forks source link

Use recommended dictConfig for logging configuration #850

Closed glatterf42 closed 2 months ago

glatterf42 commented 2 months ago

This PR is in tandem with https://github.com/iiasa/ixmp4/pull/83, where you can find an extensive description of the underlying issue. For pyam, there is no server.conf, so these parts can be disregarded.

Does this PR need to be mentioned in the release notes? Also, can we please have a quick patch release after merging this?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.0%. Comparing base (ddbb88e) to head (a058755). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #850 +/- ## ======================================= - Coverage 95.0% 95.0% -0.1% ======================================= Files 64 63 -1 Lines 6134 6151 +17 ======================================= + Hits 5828 5844 +16 - Misses 306 307 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

glatterf42 commented 2 months ago

I can't re-run the failing test, but given that the other tests (especially for py3.12) passed, I'd assume that this error is flaky and not related to the changes made in this PR.