IAMconsortium / units

Common unit definitions for integrated assessment research
GNU General Public License v3.0
20 stars 11 forks source link

Add litre gasoline-equivalent conversion #27

Closed francescolovat closed 3 years ago

francescolovat commented 3 years ago

This PR addresses the addition of the energy unit conversion of litres of gasoline-equivalent (Lge). These units are used to represent quantities in this GFEI report, from which we happened to received some data.

How to review:

codecov-commenter commented 3 years ago

Codecov Report

Merging #27 (ea8d49c) into main (9d709e9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files           4        4           
  Lines         130      130           
=======================================
  Hits           95       95           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d709e9...ea8d49c. Read the comment docs.

francescolovat commented 3 years ago

@khaeru thanks! I've just added it. Please feel free to merge it when tests will pass!

khaeru commented 3 years ago

@francescolovat sorry, but I realized belatedly that definitions.txt is organized in sections and this, being energy-related, should have gone in the "Energy" section, rather than at the very bottom of the file.

I will move the lines as I prepare a new release.

francescolovat commented 3 years ago

Thanks for making it even clearer, @khaeru !