IANW-Projects / ConservationLaws

A set of tools for numerically solving different kinds of conservation or balance laws with OpenCL.
3 stars 5 forks source link

Surface terms for ideal MHD #8

Open Kostaszki opened 5 years ago

Kostaszki commented 5 years ago

In order to use nonperiodic boundary conditions we need to implement surface terms for ideal MHD.

simonius commented 5 years ago

I finished a raw draft of the surface terms, but i have some questions concerning the meaning of some variables. Anyway i hope to upload a beta next week.

ranocha commented 5 years ago

A first version has been implemented in #28. Other possibilities can/should be added as well.

simonius commented 5 years ago

I will try more complex speeds during the next weeks.

ranocha commented 5 years ago

The issue at the boundaries might be due to the nonconservative source terms introduced for stability. We should implement corresponding corrections and test them. There are also some issues with time dependent boundary conditions and Runge-Kutta schemes, but I don't know whether they might cause the artifacts we see. I hope to be able to reserve some time for this issue next week.