search

IANetworks / Ducky-Mc-Duckerson

A Discord Bot for the Guns of Icarus Online / Alliance Discord.
GNU General Public License v3.0
8 stars 3 forks source link

Code formatting #14

Open AbbyCottontail opened 7 years ago

AbbyCottontail commented 7 years ago

At the moment the codes is not very well formatted with methods and variables all over the place. At some point, There's a need to go back and format the code.

Ontop of this, create a coding practice for the project.

AbbyCottontail commented 7 years ago

I'm up for suggestions of coding practice I should follow.

LucileDT commented 7 years ago

Formatting and organization of the code are two different things. My questions will be: 1- Do you use a framework? 2- Do you auto-format the code with your IDE? (most of them have a shortcut to do it, it indents clearly the code) 3- Do you have preferences? (e.G. camelcase vs snakecase)

AbbyCottontail commented 7 years ago

3- I actually prefer snake_case but the code is in CamelCase, all of it, so that's fine. 2- I usually format as I go along but, I think I'm following different format style, not exactly sure. My IDE does have auto formatting but for the most part I've been indenting as I go along and such. 1-I don't think I'm following a framework.

I think for the most part, it may be the organization that need doing more than the formatting.

LucileDT commented 7 years ago

Ok, if you don't use a framework, that's why you have code organization problems 🙂 Do you know the MVC pattern?

AbbyCottontail commented 7 years ago

Modal View Controller, right?

LucileDT commented 7 years ago

Yes, exactly!