RBS signatures - Githubissues

IAPark / tiktoken_ruby

Unofficial ruby binding for tiktoken by way of rust

MIT License

125 stars 26 forks source link

RBS signatures #16

Closed drnic closed 8 months ago

drnic commented 1 year ago

[x] Add sig/tiktoken_ruby.rbs signatures
[x] Introduce steep check
[x] Run steep check in default rake task
[x] Run steep check in github ci
[x] README instructions for libraries using tiktoken_ruby
[x] Confirm library "tiktoken_ruby" works for client of gem via bundle exec steep check

drnic commented 1 year ago

FWIW this is the first time I've added .rbs sigs into someone else's gem (because I decided to use .rbs in my own WIP gem and figured I'd be helpful :)

drnic commented 1 year ago

NOTE, the BpeFactory signatures weren't required by steep check, but I figured out what I think they should be from the extension.

IAPark commented 8 months ago

Thanks @drnic sorry for never merging this, trying to be more helpful with my own stuff, but still slow. If you'd like to merge this still let me know and I'll reopen this PR