IAPark / tiktoken_ruby

Unofficial ruby binding for tiktoken by way of rust
MIT License
125 stars 26 forks source link

Move `rb_sys` gem dep to gemspec #5

Closed georgeclaghorn closed 1 year ago

georgeclaghorn commented 1 year ago

Rubygems can't see dependencies in Gemfiles. Like the generated comment at the top of the Gemfile suggests, gem dependencies intended to be exposed to users and automatically installed with the gem must be listed in the gemspec.

Rubygems.org shows no runtime dependencies for tiktoken_ruby:

image

Compare to another gem with a Rust native extension:

image

Fixes #1.

jpr5 commented 1 year ago

I second this. Dependency should be required explicitly so bundler can do the right thing.