IARC-CSU / CanReg5

CanReg5 is a multi user, multi platform, open source tool to input, store, check and analyse cancer registry data.
http://www.iacr.com.fr/CanReg5
GNU General Public License v3.0
24 stars 13 forks source link

C202308 - Improve file import performance #130

Open infotel4iarc opened 1 year ago

cchenginfotel commented 1 year ago

https://github.com/infotel4iarc/CanReg5/commits/C202308-Improve_file_import

I've removed redundant variable instantiations from loops, as the variables won't change from one step to another. Some calls to CanReg "main" server have been factorized, as these calls were the main reason for the import feature being so slow.

So far, with these modifications, the import is at least twice faster if compared to the initial time. For reference on my computer:

Please note these time references change depending on the workload the computer has to manage

I also edited the code so that when the user clicks on "cancel", the cursor will switch back to the "normal" state instead of keeping the "loading" state which confused me a lot when I was testing the feature.