Special relativistic hydrodynamics - [merged]

[jmstone]

In GitLab by @emost on Feb 8, 2021, 16:00

_Merges relhydro -> master

Adds special relativistic hydrodynamics to the hydro module.

[jmstone]

In GitLab by @emost on Feb 26, 2021, 22:39

added 22 commits

• e504b529...c0ddc72c - 19 commits from branch theias/hpc/jmstone/athena-parthenon:master
• 02a1efff - Started to upgrade rel. hydro C2P
• 81a1e726 - Merge remote-tracking branch 'upstream/master' into rel_hydro
• 2c4f29f5 - New C2P appears to be working

Compare with previous version

[jmstone]

In GitLab by @emost on Feb 27, 2021, 11:24

added 1 commit

• 024247af - Initial port of rel. HLLC solver. Not yet optimized for reduced register use.

Compare with previous version

[jmstone]

In GitLab by @emost on Mar 4, 2021, 11:35

added 17 commits

• 024247af...d73877bb - 16 commits from branch theias/hpc/jmstone/athena-parthenon:master
• 08daddaa - Merge branch 'master' into rel_hydro

Compare with previous version

[jmstone]

In GitLab by @emost on Mar 8, 2021, 20:39

added 1 commit

• 3262a38e - Fixed typo

Compare with previous version

[jmstone]

In GitLab by @emost on Mar 8, 2021, 21:01

added 1 commit

• 40799fd9 - Added initial convergence check to false position method

Compare with previous version

[jmstone]

In GitLab by @jmstone216 on Mar 9, 2021, 13:27

Looks good! A few comments: (1) In the ConsToPrim function there is an inner loop of max_iterations which is set to 25. Why 25? (2) Also, does this vectorize? Perhaps it might be better add an inner vector loop over i in this par for, and check convergence only after each sweep in i? This might require testing on CPUs. (3) I notice the SoundSpeed_SR function in the EOS class is a little different than the one in Athena++. Is this form more robust? (why the changes)? (4) You did a good job in conforming to the current source code style. I am somewhat picky about style as I find sticking to one style makes the code a lot more readable. My only minor points suggestion: I like to keep the maximum line width no more than 90 characters so I don't get line wrap around in windows on my laptop.

Otherwise I approve and you can merge!

[jmstone]

In GitLab by @jmstone216 on Mar 9, 2021, 13:27

approved this merge request

[jmstone]

In GitLab by @emost on Mar 14, 2021, 19:54

added 1 commit

• 309db231 - Changed sound speed definition to better match MHD expression. Added factor...

Compare with previous version

[jmstone]

In GitLab by @emost on Mar 14, 2021, 19:55

added 15 commits

• 309db231...40a6ed62 - 14 commits from branch theias/hpc/jmstone/athena-parthenon:master
• eed9c5e0 - Merge remote-tracking branch 'upstream/master' into rel_hydro

Compare with previous version

[jmstone]

In GitLab by @jmstone216 on Mar 18, 2021, 08:21

mentioned in commit ca70eaa3ce8d28eeba1d951c2e971f1528b7ec39