Add GR Radiation (M)HD - [merged]

[jmstone]

In GitLab by @pdmullen on Nov 24, 2022, 09:13

Merges radiation -> master

Overview

This MR introduces a physics module for GR radiation transport plus coupling to (magneto)hydrodynamics. An exhaustive Wiki has been generated here, therefore, I will be brief in the MR text.

New Features

• GR Radiation Transport
• Coupling to (Magneto)hydrodynamics
• Beam sources
• Flashlight pgen
• Snake pgen
• Hohlraum pgen
• Relaxation pgen
• Diffusion pgen
• Tetrad unit test pgen
• Linear wave pgen
• Radiating torus pgen
• Restart redesign (adopted from @arzamasskiy !80)

Needs Work

• The current formulation of the radiation source term mirrors the implementation of @c-white and @yjiang3 in be7f84565b of the Athena++ gr_rad branch. I still suspect there may be some differences between this implementation and what is in @c-white's current gr_rad 73dcf16. What is the better formulation? Are they equivalent?
• The excision for radiation is underdeveloped. Radiating tori show clear problems in or about the ergosphere. Currently, we zero intensities inside $r_\mathrm{KS} = 1$ and zero intensities for angles with $\lvert n_0 \rvert \leq 0.1$. This is a hack; we need to do better.
• I added a swarm of radiation outputs. So many of these could be ripped out if we just introduced cherrypicking of output variables as was discussed in the comments of !82.

[jmstone]

In GitLab by @pdmullen on Nov 24, 2022, 09:15

added 1 commit

• 777a0864 - Remove unnecessary DualArray4D

Compare with previous version

[jmstone]

In GitLab by @pdmullen on Nov 24, 2022, 09:18

added 1 commit

• ae30a6d7 - Fix flake8 errors

Compare with previous version

[jmstone]

In GitLab by @pdmullen on Nov 24, 2022, 09:26

added 1 commit

• e2a6c007 - Fix Google C++ compliance

Compare with previous version

[jmstone]

In GitLab by @pdmullen on Nov 24, 2022, 09:28

marked this merge request as ready

[jmstone]

In GitLab by @pdmullen on Nov 24, 2022, 09:28

requested review from @jmstone216

[jmstone]

In GitLab by @pdmullen on Nov 25, 2022, 10:06

added 1 commit

• d4fef4bc - Temporarily add n_0 floor parameter

Compare with previous version

[jmstone]

In GitLab by @pdmullen on Nov 28, 2022, 09:48

added 1 commit

• 2101f85d - Consistency in radiation fluxes

Compare with previous version

[jmstone]

In GitLab by @jmstone216 on Nov 28, 2022, 14:52

What can I say? A major step forward representing a huge increase in capability, now all in master. I am sure lots of little things can be tweaked in the future, but all looks great to me now.

[jmstone]

In GitLab by @jmstone216 on Nov 28, 2022, 14:52

approved this merge request

[jmstone]

In GitLab by @jmstone216 on Nov 28, 2022, 14:52

mentioned in commit e2d4cec62fbf3ef4abb7a19a5662df5dce9787fb