search

IAS-Astrophysics / athenak

Performance-portable version of the Athena++ astrophysical AMR-MHD code using Kokkos.
BSD 3-Clause "New" or "Revised" License
36 stars 26 forks source link

Z4c amr - [closed] #536

Closed jmstone closed 3 months ago

jmstone commented 1 year ago

In GitLab by @Hengrui_Zhu on Jun 29, 2023, 24:15

_Merges z4camr -> master

Draft Version of z4c_amr merge request. SMR linear wave tested.

jmstone commented 1 year ago

In GitLab by @Hengrui_Zhu on Jun 29, 2023, 24:15

requested review from @jmstone216 and @pdmullen

jmstone commented 1 year ago

In GitLab by @mhguo on Jul 2, 2023, 16:50

There are a few "variable X was declared but never referenced" errors during the compilation, including:

~/athenak/src/outputs/history.cpp(161): warning: variable "nhydro_" was declared but never referenced
~/athenak/src/pgen/tests/z4c_linear_wave.cpp(65): warning: variable "z4c" was declared but never referenced

I was wondering whether we could fix them in this MR or in a future MR.

jmstone commented 1 year ago

In GitLab by @jmstone216 on Jul 3, 2023, 09:13

No reason why we can't fix any new compiler warnings here, as part of this MR. Once the Z4c AMR is completely ready, let's fix the warnings too.