search

IAS-Astrophysics / athenak

Performance-portable version of the Athena++ astrophysical AMR-MHD code using Kokkos.
BSD 3-Clause "New" or "Revised" License
33 stars 21 forks source link

AMR and wave extraction for z4c bbh evolution - [merged] #548

Closed jmstone closed 2 months ago

jmstone commented 9 months ago

In GitLab by @Hengrui_Zhu on Jan 17, 2024, 10:54

_Merges waveextr -> master

This merge request implements amr and gravitational wave extraction for the z4c evolution system. The default amr criteria is based on the minimum conformal factor chi. For wave extraction, first the Weyl scalar \psi_4 is calculated, interpolated onto a geodesic-grid, then decomposed into spin-weighted spherical harmonics and saved to a text file. Maybe one should output these scalars as part of the history file (?)

Comparison between gr-athena++ and athenak (extracted at different radii) image__1_

Extra Credit: Weyl scalar was first implemented by Francesco Zappa; Sommerfeld boundary condition is implemented by Jacob Field

jmstone commented 9 months ago

In GitLab by @Hengrui_Zhu on Jan 17, 2024, 10:54

requested review from @jmstone216, @jfields7, and @rashti-alireza

jmstone commented 9 months ago

In GitLab by @jmstone216 on Jan 19, 2024, 07:08

All looks good to me!

jmstone commented 9 months ago

In GitLab by @jmstone216 on Jan 19, 2024, 07:08

approved this merge request

jmstone commented 9 months ago

In GitLab by @jfields7 on Jan 19, 2024, 11:16

approved this merge request

jmstone commented 9 months ago

In GitLab by @Hengrui_Zhu on Jan 21, 2024, 19:25

added 1 commit

Compare with previous version

jmstone commented 9 months ago

In GitLab by @Hengrui_Zhu on Jan 21, 2024, 19:43

added 1 commit

Compare with previous version

jmstone commented 9 months ago

In GitLab by @rashti-alireza on Jan 23, 2024, 15:54

approved this merge request

jmstone commented 9 months ago

In GitLab by @jfields7 on Jan 23, 2024, 15:55

approved this merge request

jmstone commented 9 months ago

In GitLab by @Hengrui_Zhu on Jan 25, 2024, 13:41

added 1 commit

Compare with previous version

jmstone commented 9 months ago

In GitLab by @Hengrui_Zhu on Jan 25, 2024, 13:42

revoked approvals from @jfields7 and @rashti-alireza by pushing to the branch

jmstone commented 9 months ago

In GitLab by @rashti-alireza on Jan 25, 2024, 15:36

approved this merge request

jmstone commented 8 months ago

In GitLab by @jmstone216 on Jan 29, 2024, 09:35

mentioned in commit 0b6993694b3a8c462966ad862b890b96d9636dff