search

IAS-Astrophysics / athenak

Performance-portable version of the Athena++ astrophysical AMR-MHD code using Kokkos.
BSD 3-Clause "New" or "Revised" License
34 stars 24 forks source link

fixing the z constraint evaluation - [merged] #557

Closed jmstone closed 3 months ago

jmstone commented 8 months ago

In GitLab by @Hengrui_Zhu on Mar 4, 2024, 11:41

_Merges constraint_bugfix -> master

The Z constraint for the z4c system was incorrectly evaluated previously using the adm metric, hence not converging. This merge request fixes this bug. Also, I added constraint evaluation at the problem generator to calculate the constraint violation of the initial data

jmstone commented 8 months ago

In GitLab by @Hengrui_Zhu on Mar 4, 2024, 11:41

requested review from @jmstone216 and @jfields7

jmstone commented 8 months ago

In GitLab by @Hengrui_Zhu on Mar 4, 2024, 11:44

added 1 commit

Compare with previous version

jmstone commented 8 months ago

In GitLab by @jfields7 on Mar 4, 2024, 13:11

approved this merge request

jmstone commented 8 months ago

In GitLab by @jmstone216 on Mar 5, 2024, 13:17

mentioned in commit 0869aae864bfdeb3640c0d0a2a51146ed5a8ddc4