IATA-Cargo / ONE-Record

This repository contains the documentation & specs for the ONE Record standard.
https://onerecord.iata.org
MIT License
101 stars 52 forks source link

[Data Model/Mapping] How to store NilCarriageValueIndicator and NilCustomsValueIndicator #132

Closed mskopp closed 2 years ago

mskopp commented 2 years ago

(This question is from the XFWB-to-1R converter at https://onerecord.riege.com/ and results from uploading the example message https://onerecord.riege.com/888-11111111_XFWB.xml into the converter, warning messages 'how to handle NilCarriageValueIndicator, using Piece#declaredValueForCarriage with "NVD" as workaround' and 'how to handle NilCustomsValueIndicator, using Piece#declaredValueForCustoms with "NVD" as workaround')

If CarriageValueIndicator is decared as NVD in XFWB/FWB and/or if CustomsValueIndicator is decared as NVD in XFWB/FWB and/or, is the following correct to 'store' this information in 1R?

    "https://onerecord.iata.org/Piece#declaredValueForCarriage" : [ "NVD" ],
    "https://onerecord.iata.org/Piece#declaredValueForCustoms" : [ "NVD" ],

The assignment "declaredValueForCarriage/Customs" : "NVD" does not feel to be an obvious natural mapping.

If this is the designated assignment then it should clearly be documented in Piece / the Piece fields in the Ontology.

lambertciata commented 2 years ago

My proposal:

lambertciata commented 2 years ago

Proposal validated, add the condition that: