IATA-Cargo / ONE-Record

This repository contains the documentation & specs for the ONE Record standard.
https://onerecord.iata.org
MIT License
102 stars 51 forks source link

[Ontology] changeRequest: new fields in BookingOptionRequest: expectedSpeed, expectedCarrierProductCode #162

Closed LauraWeissgerber closed 6 months ago

LauraWeissgerber commented 1 year ago

We are missing the option / the fields in BookingOptionRequest to name

lambertciata commented 1 year ago

Hi Laura,

LauraWeissgerber commented 1 year ago

Hi Christophe,

thanks for your reply. Right now we have handlingInstructions just for pieces, not for the whole shipment. So this is planned in the next release to connect handlingInstructions for shipment?

Do you mean it like this? BookingOptionRequest - Shipment - handlingInstructions - serviceType: "speed" BookingOptionRequest - Shipment - handlingInstructions - serviceDescription: "td.Flash"

But right now we just have a range for "serviceType" of this: { "OSI" , "SPH" , "SSR" } Then we would need a new serviceType "speed" or something like that.

Regarding the carrierProductCode. Right now we have BookingOptionRequest - BookingOption - carrierProductInfo. In my option carrierProductCode should also be possible to be requested by the consumer/customer directly in the request. That's why we thought abount "expectedProductCode" in BookingOptionRequest. Alternative we could link "CarrierProduct" as "expectedCarrierProduct" in the BookingOptionRequest (BookingOptionRequest - expectedCarrierProduct - CarrierProduct). What do you think? In the response it makes sense that the productCode is part of BookingOption.

lambertciata commented 1 year ago

For carrierProductCode it's exactly as you say, we need to add the field in the BookingOptionRequest and the type will be CarrierProduct. I will include that in next release.

If I recall last MCD discussions, we have BookingOptionRequest#requestedHandling which is a string and can be used for that purpose. It is not optimal as it lacks standardization but it's not easy to find common ground on this.

LauraWeissgerber commented 1 year ago

Hi, I thought requestedHandling should be used for special handling codes... Maybe we could add "speed" to carrierProduct?

So it would look like this?

"iata:BookingOptionRequest#carrierProduct":{
  "@type": "iata:carrierProduct",
  "iata:carrierProduct#productCode": "FCP",
  "iata:carrierProduct#speed": "td.Flash",
  "iata:carrierProduct#productDescription": "string"

}, "iata:bookingOptionRequest#allotment": "A-123456789", "iata:bookingOptionRequest#expectedCommodities": "OTHPHARMA PER", "iata:bookingOptionRequest#requestType": "BookingOptionRequest", "iata:bookingOptionRequest#requestedHandling": "EAW, SEC, ICE"

lambertciata commented 6 months ago

Cleared with 3.0.0