IATA-Cargo / ONE-Record

This repository contains the documentation & specs for the ONE Record standard.
https://onerecord.iata.org
MIT License
102 stars 51 forks source link

[Ontology] Values for regulatedEntity:regulatedEntityCategory include descriptions as part of the code #178

Closed Waitak closed 6 months ago

Waitak commented 1 year ago

The allowed values for regulatedEntity:regulatedEntityCategory are listed in the ontology as:

including the descriptions as part of the code.

regulatedEntity:regulatedEntityCategory rdf:type owl:DatatypeProperty ;
                                        rdfs:domain :RegulatedEntity ;
                                        rdfs:range [ rdf:type rdfs:Datatype ;
                                                     owl:oneOf [ rdf:type rdf:List ;
                                                                 rdf:first "AO - Aircraft Operator" ;
                                                                 rdf:rest [ rdf:type rdf:List ;
                                                                            rdf:first "KC - Known Consignor" ;
                                                                            rdf:rest [ rdf:type rdf:List ;
                                                                                       rdf:first "RA - Regulated Agent" ;
                                                                                       rdf:rest [ rdf:type rdf:List ;
                                                                                                  rdf:first "RC - Regulated Carrier" ;
                                                                                                  rdf:rest rdf:nil
                                                                                                ]
                                                                                     ]
                                                                          ]
                                                               ]
                                                   ] ;
                                        rdfs:comment "Party type - e.g. RA - Regulated Agent, KC - Known Consignor, AO - Aircraft Operator, RC - Regulated Carrier"@en ;
                                        rdfs:label "regulatedEntity:regulatedEntityCategory"@en .

These should rather be just the codes (AO, KC, RA and RC):

regulatedEntity:regulatedEntityCategory rdf:type owl:DatatypeProperty ;
                                        rdfs:domain :RegulatedEntity ;
                                        rdfs:range [ rdf:type rdfs:Datatype ;
                                                     owl:oneOf [ rdf:type rdf:List ;
                                                                 rdf:first "AO" ;
                                                                 rdf:rest [ rdf:type rdf:List ;
                                                                            rdf:first "KC" ;
                                                                            rdf:rest [ rdf:type rdf:List ;
                                                                                       rdf:first "RA" ;
                                                                                       rdf:rest [ rdf:type rdf:List ;
                                                                                                  rdf:first "RC" ;
                                                                                                  rdf:rest rdf:nil
                                                                                                ]
                                                                                     ]
                                                                          ]
                                                               ]
                                                   ] ;
                                        rdfs:comment "Party type - e.g. RA - Regulated Agent, KC - Known Consignor, AO - Aircraft Operator, RC - Regulated Carrier"@en ;
                                        rdfs:label "regulatedEntity:regulatedEntityCategory"@en .

As it stands, "AO" (for example) is not a valid value for this field.

lambertciata commented 1 year ago

Hi it does make sense, will modify for next release

lambertciata commented 6 months ago

Fixed in 3.0.0 using a CodeListElement