IATA-Cargo / ONE-Record

This repository contains the documentation & specs for the ONE Record standard.
https://iata-cargo.github.io/ONE-Record/
MIT License
108 stars 53 forks source link

Fix VolumetricWeight object #276

Open lambertciata opened 3 weeks ago

lambertciata commented 3 weeks ago

In current ontology there seems to be a mistake on the way VolumetricWeight object is defined.

Image

Object contains a property called chargeableWeight which is wrong or misplaced.

As the Chargeable Weight is defined as the maximum between gross weight and volumetric weight, it need to be mentioned to avoid other stakeholders to implement the logic while viewing AWB data but it should not be in the VolumetricWeight object.

2 solutions: 1 - We deprecate VolumetricWeight object and move the chargeableWeight and conversionFactor to Piece object. 2 - We remove chargeableWeight from VolumetricWeight object and move it to Piece object, we add volumetricWeight propery to VolumetricWeight object. In that case is VolumetricWeight a Value or just a double? Which unit does it have?

Image

In current messages, the value of the volumetric weight (volumes x conversion factor) is not present.

lambertciata commented 1 week ago

VolumetricWeight shouldn't make sense at Piece level as it is airline specific. It should be only on Shipment level. Check as well if it's requried on LineItem level as well, might impact where we need to put the Volumetric Weight

lambertciata commented 6 days ago

Here is a proposal to update the data model.

Image

lambertciata commented 4 days ago

As discussed in 21Nov call: