search

IATI / D-Portal

http://d-portal.org/
Other
31 stars 23 forks source link

If an activity identifier includes [linebreak] , d-portal view and xml is not available #593

Open stevieflow opened 3 years ago

stevieflow commented 3 years ago

eg: http://d-portal.org/ctrack.html?reporting_ref=CH-FDJP-CHE109994012#view=act&aid=CH-FDJP-CHE109994012-5000101%0D%0A-%202019

This activity has blank spaces in the identifier (which is not ideal, and should be fixed)

CH-FDJP-CHE109994012-5000101 - 2019

However, it can be viewed in d-portal ^

From this page , the individual page is not accessible:

http://d-portal.org/q.html?aid=CH-FDJP-CHE109994012-5000101-%202019 http://d-portal.org/q.xml?aid=CH-FDJP-CHE109994012-5000101-%202019

It looks like all the spaces are not encoded -- I can get to the result page by manipulating the URL:

http://d-portal.org/q.xml?aid=CH-FDJP-CHE109994012-5000101%0D%0A-%202019

stevieflow commented 3 years ago

Actually - I dont think it's a [blank space] that is the problem here, but a line break!

Regardless, I wonder if this is something you can fix, so we can see the activity pages, regardless of the identifier format...

notshi commented 3 years ago

Thanks, @stevieflow - could you change the title of the thread to reflect this? ie. [line break], not [blank space].

We will take a look and fix this - though it would be good if issues like these are fixed earlier on during publishing.

Also, the IATI Registry should really disallow this. What does the Validator do with issues like these? @PetyaKangalova

notshi commented 3 years ago

Hi @PetyaKangalova @amy-silcock any guidance on this?

We really think this should be fixed upstream so it doesn't trickle down to data consumers.

amy-silcock commented 3 years ago

Hi @notshi definitely agree it's something that should be fixed by publishers rather than by d-portal. I'm of the view that it's not d-portal's job to correct publishers' data. Happy to help reach out to publishers that have incorrect iati identifiers.