search

IATI / D-Portal

http://d-portal.org/
Other
31 stars 23 forks source link

KRW to USD currency conversion issue #611

Closed andreaszenasidi closed 3 years ago

andreaszenasidi commented 3 years ago

Data users raised a concern about unusually large funds reported by the Republic of Korea in d-portal.

1. Activity KR-GOV-051-2015010319737: in the XML the Outgoing Commitment shows KRW 95,200,000 which is around USD 84,000, the same amount is shown on the d-portal activity page. However, on the summary page, $136,621,230 of Outgoing Commitments are shown which is not the correct currency conversion.

2. Activity KR-GOV-051-2020010100045: the XML reports KRW 7,140,000,000 which is around USD 6 million. The summary page shows USD 10 billion.

notshi commented 3 years ago

Thanks for raising, @andreaszenasidi this could be related to https://github.com/devinit/D-Portal/issues/485 and/or https://github.com/devinit/D-Portal/issues/465 but we will need to investigate.

notshi commented 3 years ago

Hi @andreaszenasidi looks like the problem was down to unexpected commas in IMF data (source) and how we are parsing it.

Korean won  1,774.460000    1,783.760000    NA  1,773.200000    1,768.370000    1,772.260000    1,779.290000    1,765.480000    1,764.560000    1,761.220000    1,764.070000

It looks like IMF is reporting data with commas in other currencies as well; ie. Colombian peso, Indonesian rupiah and Iranian rial so this fix, when it is checked in, will deal with those as well.

notshi commented 3 years ago

Hi, @andreaszenasidi this fix is now live.

andreaszenasidi commented 3 years ago

@notshi many thanks for the quick fix!