search

IATI / IATI-Codelists-NonEmbedded

IATI Codelists that are 'non-functional' and usually provide lookup information.
http://iatistandard.org/codelists/codelist-management/
Other
3 stars 19 forks source link

Use ISO 3166 lower case short names for Country codelist names #273

Closed andylolz closed 5 years ago

andylolz commented 5 years ago

I.e.:

screen shot 2018-10-04 at 10 21 34

ISO 3166 provides a lowercased version of the short name, e.g.: https://www.iso.org/obp/ui/#iso:code:3166:BJ

All caps is inconsistent with (I think?) every other IATI codelist, and makes this codelist significantly less useful. For instance, d-portal doesn’t use this version of the country codelist, for exactly this reason. See: https://github.com/devinit/D-Portal/issues/452#issuecomment-374399411

Would you accept a pull request that switches these to use the ISO-3166 short name lowercased versions? Thanks.

samuele-mattiuzzo commented 5 years ago

I need to verify with the BAs that this does not produce undesirable side effects or compatibility issues (possibly an irrelevant concernm, but helpful for me to understand), but it's a valid improvement! I'll get back to you as soon as I chatted with one of them 👍

andylolz commented 5 years ago

This is GREAT. Thanks so much for the swift response!

andylolz commented 5 years ago

¡…Scope creep alert…! Would also be pretty easy to pull in local short names, too. E.g. for Afghanistan, ISO have it in Farsi and Pashto: https://www.iso.org/obp/ui/#iso:code:3166:AF

(but happy to park that for now!)

samuele-mattiuzzo commented 5 years ago

Had a brief chat with the BAs, they won't have time to properly check this before tomorrow morning, so let's hold this for now (although I don't see any reason why it would get pushed back even after further investigations)!

andylolz commented 5 years ago

Excellent – sounds positive :)

stevieflow commented 5 years ago

I dont now why, but it's always been so: http://reference.iatistandard.org/101/codelists/country/index.html !

andylolz commented 5 years ago

Thanks, Steven! I guess it’s possible ISO didn’t provide lower case short names in 2012… That would be one explanation, but I’d be surprised if that were the case.

PetyaKangalova commented 5 years ago

From our point of view there is no reason why the codelist should not be changed to the lowercase version of ISO 3166 as suggested in this Github issue.

@andylolz we will accept a pull request making these changes (thank you for the suggestion!). If you are happy to add the pull request, we will then review and merge. The changelog would also require an update. We also need a post on Discus to inform the community.

andylolz commented 5 years ago

we will accept a pull request making these changes

Thanks @PetyaKangalova.

If you are happy to add the pull request, we will then review and merge.

Great – it’s here: #274.

The changelog would also require an update. We also need a post on Discus to inform the community.

Yes, that’s true. Do you want me to do this stuff? I can create a discuss post / send a pull request to update the changelog if needed. UPDATE: discuss post created.

andylolz commented 5 years ago

Fixed, merged, deployed! 🌟