IATI / IATI-Codelists-NonEmbedded

IATI Codelists that are 'non-functional' and usually provide lookup information.
http://iatistandard.org/codelists/codelist-management/
Other
3 stars 19 forks source link

Update DAC codelists according to July 2019 changes and February 2020 changes #301

Closed andylolz closed 4 years ago

andylolz commented 5 years ago

DAC CRS codelists were updated on 23/07/19. See: http://www.oecd.org/dac/financing-sustainable-development/development-finance-topics/crs-xml.htm

Replicated codelists should be updated accordingly.

andylolz commented 5 years ago

The process for getting replicated codelist changes into the standard was previously documented here: https://github.com/IATI/IATI-Extra-Documentation/blob/9c54e586/en/codelists-guides/codelist-management.rst#updates-to-non-embedded-codelists

I don’t know if this process has changed, but it’s no longer documented: http://reference.iatistandard.org/203/codelists-guides/codelist-management/#non-embedded-codelists-replicated

samuele-mattiuzzo commented 5 years ago

@andylolz we need to do a bit of looking up as to why some withdrawn codes are missing on the reference site and also check for the new updates. Earliest we can do that is Friday, so this will be taken care of at the end of this week or early next week. Thank you!

andylolz commented 5 years ago

Hi @samuele-mattiuzzo – That’s great to hear. Thanks for letting me know, and thanks for looking into this.

andylolz commented 4 years ago

DAC codelists were updated again on 2020-02-28. See: http://www.oecd.org/development/financing-sustainable-development/development-finance-standards/dacandcrscodelists.htm

I’ve contacted them to let them know about an issue with code descriptions: https://twitter.com/andylolz/status/1234785559006060544

PetyaKangalova commented 4 years ago

Thanks @andylolz . Linking to the pull request for this that I will be reviewing next week.

andylolz commented 4 years ago

Great! Thanks for the update, @PetyaKangalova.

I can see a few issues with the pull request (most notably, that automated checks are failing). Would it be helpful for me to provide comments there?

PetyaKangalova commented 4 years ago

@andylolz , yes that will be great! Thanks ! @akmiller01

akmiller01 commented 4 years ago

Looks like we will need to strip out some of those extraneous OECD-specific attributes @PetyaKangalova . Half of the XML lint errors are along the lines of:

xml/CRSChannelCode.xml:26: element codelist-item: Schemas validity error : Element 'codelist-item', attribute 'mcd': The attribute 'mcd' is not allowed.

andylolz commented 4 years ago

Here’s a list of the steps I went through when I previously updated from DAC XML: https://github.com/IATI/IATI-Codelists-NonEmbedded/pull/283#issuecomment-457626235

One of the steps in there is about removing these invalid DAC namespace elements. I can see that the PR also includes the “Vonlontary basis” [sic] statuses mentioned in the above post.

PetyaKangalova commented 4 years ago

@akmiller01 yes, this is what I expected with the extra attributes. Let's look at Andy's comment and will review on Tuesday :)

PetyaKangalova commented 4 years ago

February changes have now gone live on the IATI website so closing this issue. Will create a new one for the May changes.