Closed samuele-mattiuzzo closed 4 years ago
Great to see this moving forward! But would you mind helping me understand why you didn't proceed with #302? This PR seems to be identical to #302, except it doesn't re-add withdrawn sector categories
230
and920
.Thanks
Because I needed to understand it myself, and I could not figure out your commits due to my ineptitude around Codelists. Will look at yours as well tomorrow, thanks for pointing it out.
Okay, thanks.
If I can help clarify anything at all, please do not hesitate to ask. The same applies to all of my open pull requests – I’m happy to provide further clarification if that’s useful.
@andylolz I realised I hadn't pushed that file for some reason, but yeah our PRs are identical, I think I just found it easier to go through the codes one by one and work out with the BA what was and wasn't removed and needed re adding
Okay, great.
So since the PRs are identical, that’s equivalent to a passing review for #302, right?
[What I mean is: It would be cool if you would merge #302 over this PR.]
Hacktober eh? :P
Ha, no. #302 was created in July. Only PRs created in October count towards Hacktober.
yeah silly me 🤦♂ anyway, I'm just waiting for the 👍 from the BAs then I'll merge #302 in
Great – thanks
Great to see this moving forward! But would you mind helping me understand why you didn't proceed with #302? This PR seems to be identical to #302, except it doesn't re-add withdrawn sector categories
230
and920
.Thanks