IATI / IATI-Codelists-NonEmbedded

IATI Codelists that are 'non-functional' and usually provide lookup information.
http://iatistandard.org/codelists/codelist-management/
Other
3 stars 19 forks source link

Update DAC codelist- May 2020 #328

Closed PetyaKangalova closed 1 year ago

PetyaKangalova commented 4 years ago

@akmiller01 adding the link to the latest DAC updates: https://discuss.iatistandard.org/t/notification-iati-codelists-aligned-with-oecd-dac-codelist-last-updated-28-feb-2020/1948/5

To review change later this month as the priority now is work on the website.

akmiller01 commented 4 years ago

Hi @PetyaKangalova are you actually able to find the XML for the May 5 update? Following the links from that discussion lead me to this FTP server, which only contains the XML updated as of Feb 24: https://webfs.oecd.org/crs-iati-xml/Lookup/

The XML file available for download there is identical to the February file:

$ git diff --no-index DAC-CRS-CODES_02032020.xml DAC-CRS-CODES_05052020.xml

We may need to contact the OECD.

PetyaKangalova commented 4 years ago

@akmiller01 just got in touch and will update here. It seems to me that in the Excel file there is only one addition in the channel codelist, but will wait for OECD to update the XML and confirm if there have been other changes. Thanks!

akmiller01 commented 4 years ago

Thanks @PetyaKangalova . From the OECD's reply it sounds like only regional groupings have been updated? And regions aren't provided in XML?

PetyaKangalova commented 4 years ago

@akmiller01 yes, correct. Valerie confirmed that there has been one change in the May update under "Channel codes" (see below). However, the new code has not yet been pulled to the XML codelist. Once the XML codelist has been updated, then we can make the change. For now will put this issue on hold.

The proposal to add the International Agency for Research on Cancer (IARC) to the List of ODA-eligible international organisations (Annex 2) with an ODA coefficient of 51%, in the channel category “United Nations agencies, funds and commissions” (channel category 41000), has been approved. The channel code assigned to IARC is 41151 and the decision takes effect immediately for 2020 reporting on contributions made in 2019.

akmiller01 commented 4 years ago

PR here @PetyaKangalova https://github.com/IATI/IATI-Codelists-NonEmbedded/pull/329

andylolz commented 4 years ago

And regions aren't provided in XML?

Given IATI replicates the region codelist, it should either be included in the DAC’s XML, or IATI should update from elsewhere.

The codelist is short enough that it’s pretty quick to manually compare it with this. It looks like codes 10271035 are missing, and code 380 should be marked as withdrawn.

akmiller01 commented 4 years ago

Thanks @andylolz just pushed a commit replicating the Region codelist from the DAC XLS download: https://github.com/IATI/IATI-Codelists-NonEmbedded/pull/329/commits/5213889b2adffcd287b5c8ccb0111d28db0abd7a

I have marked withdrawal and activation dates as 2020-05-04 since that is the date of the XLS and XML files for download, but happy to amend if that should be a decision date instead or if the date should be left off entirely.

andylolz commented 4 years ago

Great – thanks Alex.

happy to amend if that should be a decision date instead

I don’t know about the dates – that’s one for you folk. There has been some previous discussion on this with Amy and Rolf I think.

I just got a notification that the DAC XML has now been updated btw.

PetyaKangalova commented 4 years ago

Hi @akmiller01 and @andylolz . I need to get back to the DAC again before I can approve the two pull requests:

  1. Channel codes- the date changes seem completely wrong to me! So I would need to ask the DAC why withdrawn code were moved back to active. Seems to me it is an error.
  2. Regional codelist- for consistency I would like for us to update this once the codes have been added to the XML. I'll see if/when this can happen.
akmiller01 commented 1 year ago

Appears related PR is merged https://github.com/IATI/IATI-Codelists-NonEmbedded/pull/329