search

IATI / IATI-Dashboard

A dashboard of various metrics, generated nightly from IATI data
http://dashboard.iatistandard.org
15 stars 20 forks source link

Reduce page size to 50 #578

Closed andylolz closed 3 years ago

andylolz commented 3 years ago

https://iatiregistry.org/api/3/action/organization_list?all_fields=true&limit=100 …only returns 50 results.

I guess this is set as a hard limit on the registry. CKAN 2.9 documentation suggests this is set in site’s configuration ckan.group_and_organization_list_all_fields_max.

So this could either be fixed in the registry config, or by reducing the page size here.

andylolz commented 3 years ago

/cc @stevieflow.

andylolz commented 3 years ago

This issue means the following publishers (and probably others, too) aren’t showing up correctly on the dashboard:

stevieflow commented 3 years ago

http://dashboard.iatistandard.org/publisher/cgiar.html also affected

nosvalds commented 3 years ago

Looks okay on Dev servers. Put fix in place on Live server, should update with the daily run in the early AM Friday.

andylolz commented 3 years ago

Great – all the examples above look good now.

nosvalds commented 3 years ago
image
andylolz commented 3 years ago

Btw I’m not sure which branch I should have PRed this to… I think the dev branch here is master; production branch is live… On publishing stats, I think dev branch is dev and production branch is master. I just PRed to the default branch on both repos.

andylolz commented 3 years ago

I’m curious which branch has actually been deployed. It looks like this PR (which was merged into master) has been deployed, but #563 (also merged into master) has not?

@nosvalds Which branch of this repo is actually running on http://dashboard.iatistandard.org ?

nosvalds commented 3 years ago

PR'ing to master is fine, we are only making individual changes on the server(s) as needed at this point.

I don't see #563 on the server, so it was never deployed back then.

andylolz commented 3 years ago

Okay so I think that means the production code isn’t in version control. That seems like a problem to me.

I don't see #563 on the server, so it was never deployed back then.

Would you be interested in deploying it? It fixes #479.

nosvalds commented 3 years ago

I appreciate the concern, but this isn't something we can prioritise right now given our work on the Unified Platform including the API Gateway, Validator V2, and Public Validator API.

andylolz commented 3 years ago

Okay, understood.