IATI / IATI-Schemas

Schema development for the International Aid Transparency Initiative.
Other
15 stars 9 forks source link

Small typos identified whilst reviewing rulesets #424

Closed amy-silcock closed 5 years ago

amy-silcock commented 5 years ago
andylolz commented 5 years ago

I'm unsure what this ticket refers to. Is it possible that it's on the wrong repo? It may also be resolved now, too.

amy-silcock commented 5 years ago

Hi @andylolz, thanks for flagging. We spotted some typos in the schema whilst working on the IATI rulesets, these are yet to be changed.

andylolz commented 5 years ago

Right, yes! So, this line references “99 – RO”:

https://github.com/IATI/IATI-Schemas/blob/f5b2b2212bc49e37165424115965bab447d4e4b8/iati-activities-schema.xsd#L886

…and this line is missing an 's':

https://github.com/IATI/IATI-Schemas/blob/f5b2b2212bc49e37165424115965bab447d4e4b8/iati-activities-schema.xsd#L1213

amy-silcock commented 5 years ago

Feel free to send over some PRs to fix them if you fancy ;)

andylolz commented 5 years ago

Feel free to send over some PRs to fix them if you fancy ;)

Kk, done! (#432; #433; #434).

andylolz commented 5 years ago

I guess this is fixed & can be closed.

amy-silcock commented 5 years ago

Thanks @andylolz