IATI / design-system

A design system for IATI products.
https://iati.github.io/design-system/
0 stars 1 forks source link

Add brand documentation to Storybook #7

Closed tillywoodfield closed 2 months ago

tillywoodfield commented 2 months ago
robredpath commented 2 months ago

Thanks for this, @tillywoodfield !

When I run this locally, the fonts that are supposed to be Pragmatica display as Helvetica - presumably because of licensing? Will this work when it's live on the internet somewhere?

Other than that, I think this is going in the right direction!

tillywoodfield commented 2 months ago

@robredpath oops I missed the actual font import line, thanks for pointing that out! I've copied it from the standard website and added here, assuming it's all licensed in one place and okay to reuse that.

Also, I noticed that it only provides a single font weight for the body font (chalet-london-sixty) so bold text doesn't display correctly. I think we'll need to look in Adobe Fonts for how that is configured.

robredpath commented 2 months ago

Thanks @tillywoodfield ! I've pinged on MM to check on the licensing question.

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: