Refactor resources tests - integrate versions and improve test coverage

IATI / pyIATI

pyIATI - a developer's toolkit for IATI - Deprecated - No longer supported

MIT License

5 stars 5 forks source link

Refactor resources tests - integrate versions and improve test coverage #297

Closed hayfield closed 6 years ago

hayfield commented 6 years ago

Make sweeping and wide-ranging improvements to tests of the resources module.

The two key purposes of these changes are:

Ensure resources functions handle versions as expected
Significantly improve direct test coverage (rather than the indirect testing that occurred previously)

hayfield commented 6 years ago

This is not yet complete, and requires create_codelist_path() and get_codelist_paths() to be tested.

The PR is here at this point to allow for Github to be used for a code review.

hayfield commented 6 years ago

https://github.com/IATI/pyIATI/issues/308 turns the TODOs about improving the distinction between Embedded and Non-Embedded Codelists (as noted in review comments) into an Issue.