IAU-ADES / ADES-Master

ADES implementation based on a master XML file
26 stars 7 forks source link

Missing astrometry catalogs in packUtils.catCodes #21

Closed stevenstetzler closed 10 months ago

stevenstetzler commented 1 year ago

I've identified that at least catalog code X is missing from the packUtils.catCodes dictionary. It maps to Gaia3E according to this and this. Additionally, it looks like the mapping for W: 'UCAC5' is wrong, it should be W: 'Gaia3' and Y: 'UCAC5'. A few more seem to be missing based on what's available on both those pages.

From what I can tell, the mapping should be

catCodes = { ' ': 'UNK',
             'a': 'USNOA1',
             'b': 'USNOSA1',
             'c': 'USNOA2',
             'd': 'USNOSA2',
             'e': 'UCAC1',
             'f': 'Tyc1',
             'g': 'Tyc2',
             'h': 'GSC1.0',
             'i': 'GSC1.1',
             'j': 'GSC1.2',
             'k': 'GSC2.2',
             'l': 'ACT',
             'm': 'GSCACT',
             'n': 'SDSS8',
             'o': 'USNOB1',
             'p': 'PPM',
             'q': 'UCAC4',
             'r': 'UCAC2',
             's': 'USNOB2',  # USNOB2 missing on ADES web page
             't': 'PPMXL',
             'u': 'UCAC3',
             'v': 'NOMAD',
             'w': 'CMC14',
             'x': 'Hip2',
             'y': 'Hip1',
             'z': 'GSC',
             'A': 'AC',
             'B': 'SAO1984',
             'C': 'SAO',
             'D': 'AGK3',
             'E': 'FK4',
             'F': 'ACRS',
             'G': 'LickGas',
             'H': 'Ida93',
             'I': 'Perth70',
             'J': 'COSMOS',
             'K': 'Yale',
             'L': '2MASS',
             'M': 'GSC2.3',
             'N': 'SDSS7',
             'O': 'SSTRC1',
             'P': 'MPOSC3',
             'Q': 'CMC15',
             'R': 'SSTRC4',
             'S': 'URAT1',
             'T': 'URAT2',  # URAT2 missing on ADES web page
             'U': 'Gaia1',
             'V': 'Gaia2',
             'W': 'Gaia3',  # updated
             'X': 'Gaia3E',  # new
             'Y': 'UCAC5',  # new # UCAC5 mission on ADES web page
             'Z': 'ATLAS2', # new
             '0': 'IHW', # new
             '1': 'PS1_DR1', # new
             '2': 'PS1_DR2', # new
             '3': 'Gaia_Int', # new
             '4': 'GZ', # new
             '5': 'UBSC', # new (this might be wrong...USNO-UBAD = USNO Bright-Star Astrometric Database = USNO Bright-star Catalog = USBC ?)
             '6': 'Gaia_2016', # new
           }
stevenstetzler commented 1 year ago

@federicaspoto What do you think of this? Does this look right to you? I will open a PR to made a change to the code if it looks good.

federicaspoto commented 1 year ago

@stevenstetzler yes, it looks good to me. Thanks for checking it!